Jung-Sang Ahn

Results 125 comments of Jung-Sang Ahn

If the answer is 1) `auto_forwarding_` is disabled, 2) the first case, 3) only the callback is missing, I believe the below one will be the fix to your issue....

@Steamgjk It does batching. https://github.com/eBay/NuRaft/blob/b1f7c07aaf0e263159ac3a530c1d7a9ecc5e741b/include/libnuraft/raft_params.hxx#L389-L393

@Steamgjk If the connection to a follower is idle, the request is sent immediately. If the previous request is in flight, the next requests are sent as soon as it...

It is not a simple network partition -- the server (who initiates the pre-vote) still can see the majority of servers, but not the leader. And the leadership is still...

@metalicjames I'm not sure I get your concern correctly. Let me rephrase it like this: *when there are lagging followers that are not in the quorum, and cannot keep up...

There is an API to get peer info: https://github.com/eBay/NuRaft/blob/877a60a34d7cf3ed2fe273c05f8ff9e6fb887172/include/libnuraft/raft_server.hxx#L561-L566 You can detect such a log gap by checking `max - min > threshold` or various other ways. By the way,...

Hi @cklxiaocui The semantic of `compact` is to remove all logs up to given `last_log_index` (including itself), so your implementation looks ok. Isn't it because of race condition between calling...

+) Also you should return `true` once compaction is done correctly.

Hi @duke8253 If you want to use a pre-defined cluster (so that they form a cluster as soon as they start running), please refer to this comment: https://github.com/eBay/NuRaft/issues/196#issuecomment-817033567 And note...

Before diving into the review, what is the purpose of this commit? Building NuRaft has no problem with openssl, and if you want to define a custom path, you can...