pxf icon indicating copy to clipboard operation
pxf copied to clipboard

Modifying Tinc Tests for GP7x

Open hpandeycodeit opened this issue 3 years ago • 0 comments
trafficstars

Modifying the tinc tests so that they can pass for GP7x as well as continue to pass for earlier versions of GPDB ( 6x, 5x).

  • In some of the tests, a GUC set extra_float_digits=0; is set. This GUC has a default value of 1 in PG12 and thus the columns of type REAL displays one digit extra. So to keep the behavior consistent, setting this to 0.

  • Some of the answer test files I have modified the Order by clause to add another column to maintain the same order of the records across versions because the ordering for the results is little different in GP7 coming out a little different than the earlier versions.

  • There is a change in ProjectionInfo in PG12. i.e, how the plan is getting generated and how it's defining the projection columns Ref (https://github.com/greenplum-db/gpdb/commit/b10967eddf964f8c0a11060cf3f366bbdd1235f6) . So changed a couple of test cases to accordingly.

GpupgradeTest.testGpdbUpgradeScenario test is not passing due to python3 in GP7 vs we are using python2 in our tinc tests. So skipping this test.

hpandeycodeit avatar Oct 10 '22 16:10 hpandeycodeit