gpdb icon indicating copy to clipboard operation
gpdb copied to clipboard

Add assertions in GetTableAmRoutine to check greenplum-specific tableAM routines

Open reshke opened this issue 2 years ago • 19 comments

if somebody defines TableAM method in Greenplum, without specifying dml_init/dml_finish functions, this will cause segfault (for example, table_dml_finish call in ExecEndModifyTable method)

Here are some reminders before you submit the pull request

  • [x] Add tests for the change
  • [x] Document changes
  • [x] Communicate in the mailing list if needed
  • [x] Pass make installcheck
  • [x] Review a PR in return to support the community

reshke avatar Sep 23 '23 20:09 reshke