Resolve one GPDB_12_MERGE_FIXME in describe.c

[yanwr1]

trafficstars

IN GPDB7, we fill the storage type according to the access method oid of the pg_am system catalog. Except the heap table and append only table, we can't create correspond access method in pg_am for other storage types. Just remove the fixme.

Here are some reminders before you submit the pull request

• [ ] Add tests for the change
• [ ] Document changes
• [ ] Communicate in the mailing list if needed
• [ ] Pass make installcheck
• [ ] Review a PR in return to support the community

[adam8157]

Can't we create an access method?

I would recommend displaying the access method name if isGPDB7000OrLater().

ref: https://www.postgresql.org/docs/current/sql-create-access-method.html

[yanwr1]

Can't we create an access method?

I would recommend displaying the access method name if isGPDB7000OrLater().

ref: https://www.postgresql.org/docs/current/sql-create-access-method.html

Yes, display the access method name is better, and we should better compare the access method handler oid

[adam8157]

I was suggesting displaying the AM name, like heap, ao_row, ao_column, or the name of any user-defined AM.

[yanwr1]

I was suggesting displaying the AM name, like heap, ao_row, ao_column, or the name of any user-defined AM.

I see, but sometimes we still don't know the storage type according to the access method name, especially for user-defined AM.