gpdb icon indicating copy to clipboard operation
gpdb copied to clipboard

Published 20 hours ago • verified publisher icon greenplum-db

Resolve GPDB_12_MERGE_FIXMEs in explain.c / explain_gp.c

Open Aegeaner opened this issue 3 years ago • 6 comments
trafficstars

Here are some reminders before you submit the pull request

  • [x] Add tests for the change
  • [ ] Document changes
  • [ ] Communicate in the mailing list if needed
  • [X] Pass make installcheck
  • [ ] Review a PR in return to support the community

Aegeaner avatar Mar 07 '22 07:03 Aegeaner

How is this PR going?

adam8157 avatar May 13 '22 08:05 adam8157

How is this PR going?

I haven't noticed for the review comments for several days, now the comments are all addressed.

Aegeaner avatar May 24 '22 14:05 Aegeaner

@Aegeaner and I both think this PR needs more care, we two need more time to refactor the cdb instruments used by explain.

Mark it as a draft for now.

adam8157 avatar Jun 20 '22 03:06 adam8157

@Aegeaner (cc @adam8157 ) Can we restart work on this soon?

soumyadeep2007 avatar Aug 10 '22 16:08 soumyadeep2007

@soumyadeep2007 Sure, it's on our backlog, I have noted all the related issues mentioned by this PR or not. I will schedule it.

adam8157 avatar Aug 15 '22 03:08 adam8157

I have just rebased this PR on the master branch since https://github.com/greenplum-db/gpdb/pull/13690 & https://github.com/greenplum-db/gpdb/pull/14031 have been merged there and have influence on explain behaviours.

Aegeaner avatar Sep 06 '22 06:09 Aegeaner