gpdb icon indicating copy to clipboard operation
gpdb copied to clipboard

Published 20 hours ago • verified publisher icon greenplum-db

Reconcile workfile manager and SharedFileSets in Greenplum 7

Open asimrp opened this issue 4 years ago • 2 comments

Greenplum version or build

Greenplum 7, post PostgreSQL 12 merge

The workfile_mgr_test.c has several merge fixmes and dead code. All of it is related to legacy workfile manager feature. The new SharedFileSet framework from PostgreSQL is merged in Greenplum 7. This serves the same purpose as workfile manager - share temporary files (intermediate work during sorting) among multiple backend processes. This issue to explore whether workfile manager can be replaced entirely with SharedFileSet facility? If yes, let's get it done. Otherwise, figure out a way to reconcile the two facilities without hampering future merges, testability and readability of code.

asimrp avatar Jun 30 '21 12:06 asimrp

Do we need add some test for BufFileCreateShared in workfile_mgr_test.c?

wfnuser avatar Jun 06 '22 05:06 wfnuser

@z-wenlin you did some related work, take this a look?

adam8157 avatar Aug 01 '22 05:08 adam8157

@z-wenlin are we tracking this for 7X? @adam8157

dpandhi-git avatar Nov 21 '22 12:11 dpandhi-git

@dpandhi-git Not yet.

adam8157 avatar Nov 22 '22 01:11 adam8157