gpdb icon indicating copy to clipboard operation
gpdb copied to clipboard

Address minor lints in gpMgmt build

Open bradfordb-vmware opened this issue 3 years ago • 6 comments

  • use $(PYTHON) as determined by configure instead of relying on python3 being on the path
  • use $(libdir) instead of $(prefix)/lib

Authored-by: Bradford D. Boyle [email protected]

bradfordb-vmware avatar Apr 09 '21 16:04 bradfordb-vmware

As for renaming python3 to $(PYTHON), I thought python3 is the official executable name that will be installed on all systems; why would we want to allow it to be modified?

@jmcatamney has a lot of context here.

dkrieger-pvtl avatar Apr 09 '21 17:04 dkrieger-pvtl

As for renaming python3 to $(PYTHON), I thought python3 is the official executable name that will be installed on all systems; why would we want to allow it to be modified?

There's no guarantee that "the first thing we find on the path called python3" is even the desirable python (more importantly, it's likely not where you want to search for your dependencies). Typical scenario: /usr/bin/python3 being Python 3.4, but developer wants to build pl/Python using Python 3.9. She would do ./configure /* flags */ PYTHON=/usr/bin/python3.9.

@bradfordb-vmware is that what inspired this change?

d avatar Apr 10 '21 23:04 d

There's no guarantee that "the first thing we find on the path called python3" is even the desirable python (more importantly, it's likely not where you want to search for your dependencies).

I see; this PR is about building the python3 dependencies that we will run with. Then it likely makes sense...this is a pre-install-time action so we need to "bootstrap" to build our dependencies. Once installed, we currently use the PATH/PYTHONPATH to resolve which Python to call via /usr/bin/env python3.

There is currently an effort going on to define the execution environment for Python scripts(e.g. CM utilities).

Note that our general non-python execution environment also works this way; that is gpstart is found via essentially /usr/bin/env gpstart, e.g the gpstart that is resolved by the shell.

dkrieger-pvtl avatar Apr 12 '21 16:04 dkrieger-pvtl

@bradfordb-vmware this PR is sitting in draft status for more than a year. Any plans to bring it to prime-time or no more issue on newer versions and can be closed?

ashwinstar avatar Aug 16 '22 22:08 ashwinstar

@ashwinstar Sorry, this sort of fell of my radar. It looks like there is a merge conflict now so I'll rebase, retest, and move to ready to review.

bradfordb-vmware avatar Aug 16 '22 23:08 bradfordb-vmware

@ashwinstar Sorry, this sort of fell of my radar. It looks like there is a merge conflict now so I'll rebase, retest, and move to ready to review.

@bradfordb-vmware I believe you fixed all the conflicts and this might be ready to be merged

ashwinstar avatar Sep 02 '22 18:09 ashwinstar