planet4 icon indicating copy to clipboard operation
planet4 copied to clipboard

PLANET-6407 Spreadsheet block: indicators are not present

Open planet-4 opened this issue 3 years ago • 11 comments

Example Page

When a user wants to sort the order of the content appearing in a spreadsheet there are no indicators appearing to inform the user this is even possible.

There is also no reset option to return the table to the default view.

Screenshots

Screenshot Screenshot

Reporter: ktolen
Sections: Block: Spreadsheet

Potentially affected repositories: planet4-plugin-gutenberg-blocks

JIRA ticket: https://jira.greenpeace.org/browse/PLANET-6407

planet-4 avatar Sep 30 '21 09:09 planet-4

I would like to work on this issue.

VallariAg avatar Oct 01 '21 17:10 VallariAg

@VallariAg Go for it!

GP-Dan-Tovbein avatar Oct 01 '21 17:10 GP-Dan-Tovbein

@VallariAg FYI, here is the ticket url for a more information

GP-Dan-Tovbein avatar Oct 01 '21 17:10 GP-Dan-Tovbein

Hi @VallariAg :wave: Are you working on this? Do you require any assistance from the team?

comzeradd avatar Oct 22 '21 10:10 comzeradd

Sorry, I'll work on this and will ask for help when I get stuck. Sorry for the delay!

VallariAg avatar Oct 22 '21 17:10 VallariAg

Hi @comzeradd @VallariAg

If this issue is not currently being worked on, I can take this up

artze avatar Feb 01 '22 01:02 artze

Go for it! thank you!

On Mon, Jan 31, 2022 at 6:31 PM artze @.***> wrote:

Hi @comzeradd https://github.com/comzeradd @VallariAg https://github.com/VallariAg

If this issue is not currently being worked on, I can take this up

— Reply to this email directly, view it on GitHub https://github.com/greenpeace/planet4/issues/164#issuecomment-1026391459, or unsubscribe https://github.com/notifications/unsubscribe-auth/APR5PAVP7575IQLLFDC4T4TUY4ZYZANCNFSM5FB3X6KQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- suzi grishpul Planet 4 Product Manager, Greenpeace International pronouns: they/them/theirs location: Denver, CO, USA (GMT/UTC-6)

*Book some time with me on Fridays: *Office Hours https://calendly.com/suzi-grishpul/office-hours

suzi-greenpeace avatar Feb 01 '22 13:02 suzi-greenpeace

Hi @comzeradd @VallariAg

If this issue is not currently being worked on, I can take this up

Yes, sorry, I haven't been able to work on it. Go ahead :)

VallariAg avatar Feb 01 '22 17:02 VallariAg

Alright, I will take this up :)

artze avatar Feb 01 '22 23:02 artze

@comzeradd

Hi, I got a question.

At first render when the table is not sorted (like below), is there a preference on what kind of icon we should display next to the column titles? image

I'm thinking something like the following: image

+++

I'd also like to keep the new icon consistent with the existing asc / desc ArrowIcon. Would like to know your thoughts on the best way to achieve this, e.g.:

  • Draw a new icon that looks similar to the current one and use its svg
  • Use an icon pack (which might involve changing the existing icons)
  • etc.

artze avatar Feb 05 '22 09:02 artze

@magalifatome do we have a preference on how this icon should look? For reference, check the example page and sort by a column to see the sort icon.

comzeradd avatar Feb 07 '22 09:02 comzeradd