planet4-master-theme icon indicating copy to clipboard operation
planet4-master-theme copied to clipboard

Published 20 hours ago • verified publisher icon greenpeace

Revert fix added in Planet-6060

Open sagarsdeshmukh opened this issue 2 years ago • 6 comments

As the WP-v5.8 resolved the core issue(https://core.trac.wordpress.org/ticket/52050), no need of this patch.

Ref: PLANET-6060

Old PR

sagarsdeshmukh avatar Oct 12 '21 07:10 sagarsdeshmukh

Test instance is ready :rocket:

:new_moon: tavros | admin | blocks report | CircleCI | composer-local.json

:watch: 2023.02.23 08:45:30

planet-4 avatar Oct 12 '21 08:10 planet-4

I haven't tested it locally yet, but on the test instance typing on the visual editor doesn't seem to work 🤔

comzeradd avatar Oct 13 '21 09:10 comzeradd

I haven't tested it locally yet, but on the test instance typing on the visual editor doesn't seem to work 🤔

For me its working on Google Chrome, but now I just tested it on FF and it doesn’t 😬 Are you also testing on the FF?

sagarsdeshmukh avatar Oct 13 '21 10:10 sagarsdeshmukh

Hm.. actually for me it doesn't work in either Chrome or Firefox

comzeradd avatar Oct 13 '21 11:10 comzeradd

Strange! We will hold this PR for now. I updated the "Do not merge" label.

sagarsdeshmukh avatar Oct 13 '21 11:10 sagarsdeshmukh

Possibly it's only on MacOS now, there's a separate core ticket for that https://core.trac.wordpress.org/ticket/53644

Inwerpsel avatar Jan 03 '22 09:01 Inwerpsel

This seems to work for me now (locally). @sagarsdeshmukh can you rebase and do a final test?

comzeradd avatar Feb 23 '23 08:02 comzeradd

PLANET-6060

This seems to work for me now (locally). @sagarsdeshmukh can you rebase and do a final test?

The issue was reported for TinyMce editor, but right now the page header fields moved to sidebar and it's without TinyMce editor so we don't need this patch fix. I rebase the PR 👍

sagarsdeshmukh avatar Feb 23 '23 08:02 sagarsdeshmukh