poly2tri Fix compiler warnings

x and y in Triangle::OppositePoint() are set but not used.

The loop in Sweep::~Sweep() compares signed and unsigned values.

Jan 20 '17 21:01 ojwb

Check out my fork where these issues have been fixed: https://github.com/jhasse/poly2tri

Sep 11 '18 10:09 jhasse

Check out my fork where these issues have been fixed: https://github.com/jhasse/poly2tri

Did you try to submit your fork as PR?

Oct 17 '21 13:10 kloczek

@greenm01 Neither of the fixes in my PR seem to have been addressed:

https://github.com/greenm01/poly2tri/blob/a922022da4c0d3a55b1d6b6d634219caea653053/poly2tri/common/shapes.cc#L121

https://github.com/greenm01/poly2tri/blob/a922022da4c0d3a55b1d6b6d634219caea653053/poly2tri/sweep/sweep.cc#L843

Jan 30 '24 20:01 ojwb

Did you try to submit your fork as PR?

Not yet, because the last time I've checked this repository look abandoned. But that seems to have changed two weeks ago.

@greenm01 Would you be interested in merging my fork back into your repository?

Also see https://github.com/microsoft/vcpkg/pull/26301 about this.

Jan 31 '24 20:01 jhasse