portainer-stack-utils icon indicating copy to clipboard operation
portainer-stack-utils copied to clipboard

Several changes

Open greenled opened this issue 6 years ago • 6 comments

Hi @tortuetorche.

This is a PR to 1-0-next, a branch I created to keep polishing the Bash version and eventually (no hurries) merge it into a 1-0-stable branch (still to be created when v1.0.0 is released). It contains your latest changes to psu and Dockerfile files, and some changes to Readme.md too. I though you would be short of time so, I cleaned the history a bit by myself . Changes related with CI and Docs were intentionally left out for later, let's address those topics on different issues and PRs. Let's continue here the non-ci discussion rather than in #4. Please check everything is ok and if we are good to go, merge. This not a v1.0.0 yet, but it's on its way.

greenled avatar Aug 11 '19 17:08 greenled

Hey @tortuetorche are you still interested on this MR?

greenled avatar Nov 06 '19 04:11 greenled

Hi @greenled,

Yes I'm! I just need to find some time to work on this and also test and include changes from #33

Have a good day, Tortue Torche

tortuetorche avatar Nov 06 '19 08:11 tortuetorche

Ok, looking forward for your work.

greenled avatar Nov 06 '19 16:11 greenled

Hi @greenled ,

I push some commits, but it's still WIP, I need to test the Vincenzo Cerbone commits (#33)

Have a good day, Tortue Torche

tortuetorche avatar Dec 04 '19 15:12 tortuetorche

Hi @greenled,

This pull request is now complete!

So feel free to merge it.

Cheers, Tortue Torche

tortuetorche avatar Dec 11 '19 08:12 tortuetorche

Hi @tortuetorche Sorry, I've been pretty busy and unresponsive these weeks, my bad. I'm looking at your work. Regards.

greenled avatar Dec 12 '19 18:12 greenled