Lockfile is not included

[hulkoba]

Sometimes PRs come in without the lockfile being updated.

This might be caused by GitHub or npm issues. The npm i command fail, and the lockfile update is not included.

Maybe we should include a "tried to build a lockfile, but it failed with…" comment somewhere.

[gr2m]

I think I just had one such instance here: https://github.com/octokit/rest.js/pull/1139

[msrose]

I've encountered a similar problem on this branch https://github.com/tophat/eslint-config/compare/master...tophat:greenkeeper%2Feslint-plugin-jest-22.1.0: lockfile was not updated, so the build fails because our CI is configured to install with the --frozen-lockfile flag.

[markwhitfeld]

We are also getting this. Every attempt that Greenkeeper makes to update a package fails because it has not updated the lockfile. see: https://github.com/ngxs/store/pull/686 we are also using the --frozen-lockfile flag in our CI

[christophercr]

Same problem here, for this branch: https://github.com/NationalBankBelgium/stark/pull/902

[paglias]

Same problem with our repo, see an example at https://github.com/HabitRPG/habitica/pull/10887/files

It started after we upgraded our project to use node 10 and npm 6

[btkostner]

Also experiencing this issue.

Issue: https://github.com/elementary/houston/issues/695 Travis CI: https://travis-ci.org/elementary/houston/jobs/462979586

[znarf]

I think we have it here too. Don't think we changed anything significant in our repository.

Latest with Lockfile: https://github.com/opencollective/opencollective-frontend/pull/1121

First without Lockfile: https://github.com/opencollective/opencollective-frontend/pull/1131

https://github.com/opencollective/opencollective-frontend/pulls?utf8=%E2%9C%93&q=is%3Apr+label%3Agreenkeeper

[freaktechnik]

Just had this for https://github.com/freaktechnik/justintv-stream-notifications/issues/451 -> https://github.com/freaktechnik/justintv-stream-notifications/compare/greenkeeper/babel-plugin-transform-react-remove-prop-types-0.4.21

and

https://github.com/freaktechnik/justintv-stream-notifications/issues/452 -> https://github.com/freaktechnik/justintv-stream-notifications/compare/master...freaktechnik:greenkeeper%2Fwebpack-4.27.0

and

https://github.com/freaktechnik/transifex-loader/issues/63 -> https://github.com/freaktechnik/transifex-loader/compare/master...freaktechnik:greenkeeper%2Fwebpack-4.27.0

And I'd expect more to come with this webpack update consistently missing the lockfile so far for me.

[janl]

Heads up: we are actively monitoring this and are currently adding more metrics and logs to our systems to be able to better troubleshoot this. While doing so, we’ve seen an uptick in lockfile builds in our existing metrics, so things should look a lot more normal now.

[janl]

Thanks everybody for reporting in and thank you for your patience. We apologise for the inconveniencess

[jakebolam]

@janl still seeing issues on our side. ^ Referenced a few above

[markwhitfeld]

Only recently installed greenkeeper in the NGXS repo and have received no value from this so far due to this issue. Please resolve ASAP (Linked issues above ^). EDIT: Apologies if the tone of the above message sounded a bit harsh. I will patiently wait as long as it takes to get his resolved. Such an amazing project I must say!

[gr2m]

@markwhitfeld I’m sorry for the trouble Mark. I know that the Greenkeeper team is working on it, but as it’s weekend now it might take until Monday for an update

[krousseau-cs]

@markwhitfield, we've had it installed for 2 months now and are in the same boat. Super frustrating...

[jakebolam]

Anything the community can help with?

Happy to help/contribute/debug

Greenkeeper is awesome, and we will do anything to keep it that way

[DanielHabenicht]

I've got the same issues on my package, rendering Greenkeeper almost useless e.g.:

• https://github.com/DanielHabenicht/ngx-propagation-stop/issues/32
• https://github.com/DanielHabenicht/ngx-propagation-stop/issues/28
• https://github.com/DanielHabenicht/ngx-propagation-stop/issues/27
• https://github.com/DanielHabenicht/ngx-propagation-stop/issues/26

Also happens for PRs: https://github.com/DanielHabenicht/ngx-propagation-stop/pull/33

Keep up the good work 👍

[gr2m]

@DanielHabenicht it didn’t happen to me for a longer time now, the PRs you linked are quite old, you might need to fix them up manually. Do you see it happening in new PRs?

[DanielHabenicht]

Thanks for your comment @gr2m. I've checked a newer branch and there are chore(package): update lockfile package-lock.json commits. Seems to be fixed for me.

[markwhitfeld]

Seems to be fixed for my repo! Thank you.

[gr2m]

FYI, I saw it happen several times today again, they are all about a new @octokit/rest update

• https://github.com/octokit/plugin-retry.js/issues/14
• https://github.com/gr2m/octokit-rename-branch/issues/5
• https://github.com/octokit/plugin-throttling.js/issues/50
• https://github.com/gr2m/octokit-create-pull-request/issues/3
• https://github.com/octokit/plugin-enterprise-compatibility.js/issues/3
• https://github.com/gr2m/octokit-pinned-issues/issues/3

[jakebolam]

I have also recently seen this again, across orgs, no yarn.lock file included failing CI.

https://github.com/all-contributors/all-contributors-bot/issues/194

[znarf]

We're also experiencing it.

• https://github.com/opencollective/opencollective-frontend/pull/1610
• https://github.com/opencollective/opencollective-frontend/pull/1611
• https://github.com/opencollective/opencollective-frontend/pull/1613
• https://github.com/opencollective/opencollective-api/pull/1841
• https://github.com/opencollective/opencollective-api/pull/1843

[gr2m]

Just happened again

[james-nash]

We intermittently get this too. Our CI build uses npm ci, so when package.json is updated but package-lock.json is not, it complains that the two are out of sync and the build fails.

Here's an example of a branch Greenkeeper bot created that only updated the package.json file: https://github.com/buildit/gravity-ui-web/compare/develop...buildit:greenkeeper%2Fmonorepo.commitlint-20190715185122

The failing CI log is here: https://travis-ci.org/buildit/gravity-ui-web/builds/559077837?utm_source=github_status&utm_medium=notification

...and yet, other times (on the exact same Github repo) Greenkeeper correctly updates both and everything is fine: https://github.com/buildit/gravity-ui-web/pull/327/files

As far as I can tell from the docs, it should always update the lock file too so I can only assume this is a bug in Greenkeeper :-(