greenkeeper icon indicating copy to clipboard operation
greenkeeper copied to clipboard

In range update branches not deleted after issue is closed manually

Open hisuwh opened this issue 5 years ago • 3 comments

I have transient build failures on my CI and so erroneously get "An in-range update of XYZ is breaking the build".

If I close this issue manually, I expect greenkeeper to delete the branches it created to build with these versions.

However it does not:

image

hisuwh avatar Oct 24 '18 09:10 hisuwh

These issues should also be closed if the build is reran and suceeds

hisuwh avatar Nov 09 '18 11:11 hisuwh

Hello and thanks for the report! That’s actually a bit tricky for us, because we can’t tell whether you might still need the branch; after all, an issue can be reopened anytime, and it’s much more difficult for us to reconstruct the branch as it was when that issue was opened than to just leave it up to the users. If we deleted issue branches we’d be breaking other peoples’ workflows.

As for handling transient build failures: if the issue is closed and the re-run is successful, Greenkeeper tries to delete the branch already, does this not work in your case?

espy avatar Nov 29 '18 11:11 espy

This makes sense so I can see why you wouldn't want to delete the branches for failed builds.

No this isn't working for me you can see in my screenshot above (or at least wasn't at this point in time - I will retry next time this occurs and report back): image

This is also problematic for me because requeing non PR builds is not simple with my CI tool. My other issue might help with this though I see you have commented on that also.

Really my issues stem from my CI tool but I hold a lot a more faith that you guys will implement some fix than them.

hisuwh avatar Nov 29 '18 12:11 hisuwh