Migration to guzzle incomplete?

[twoodard-datto]

Hi @greenfieldtech-nirs, the changes merged in PR https://github.com/greenfieldtech-nirs/phpari/pull/49 seems to break functionality. Some examples of errors introduced with the changes are below:

PHP Notice: Undefined property: asterisk::$pestObject in /var/ari/vendor/greenfieldtech-nirs/phpari/src/interfaces/asterisk.php on line 113 PHP Fatal error: Call to a member function get() on a non-object in /var/ari/vendor/greenfieldtech-nirs/phpari/src/interfaces/asterisk.php on line 113 PHP Notice: Undefined index: protocol in /var/ari/vendor/greenfieldtech-nirs/phpari/phpari.php on line 100 PHP Notice: Undefined property: asterisk::$pestObject in /var/ari/vendor/greenfieldtech-nirs/phpari/src/interfaces/asterisk.php on line 113 PHP Fatal error: Call to a member function get() on a non-object in /var/ari/vendor/greenfieldtech-nirs/phpari/src/interfaces/asterisk.php on line 113 PHP Notice: Undefined index: protocol in /var/ari/vendor/greenfieldtech-nirs/phpari/phpari.php on line 100 PHP Notice: Undefined property: phpari::$ariEndpoint in /var/ari/lib/StasisAppCore.php on line 56 PHP Notice: Undefined property: asterisk::$pestObject in /var/ari/vendor/greenfieldtech-nirs/phpari/src/interfaces/asterisk.php on line 113 PHP Fatal error: Call to a member function get() on a non-object in /var/ari/vendor/greenfieldtech-nirs/phpari/src/interfaces/asterisk.php on line 113

So at first glance I am guessing that the React guzzle refactor is incomplete possibly? I would have expected changes in all of the interface files instead of just applications.php. Since this is a fairly significant change can it be done in a different branch or version so that we can set the old version in our composer.json until the refactor is stable/complete?

[greenfieldtech-nirs]

There best would be the use 'release-3' branch, which is the latest stable branch. The guzzle updates are far from being complete or tested. Real life kind'a take its toll and thus, I don't have much time to work on this project.

I'll be KamailioWorld early May, so I may have a couple of days time to resolve the guzzle issues.

[twoodard-datto]

Thanks for the info on release-3 branch. Regarding real life taking its toll, that's certainly understandable. The work you have done and are continuing to put in is much appreciated by myself and others.