green-metrics-tool icon indicating copy to clipboard operation
green-metrics-tool copied to clipboard

Tests run_until should trigger automatic cleanup

Open ArneTR opened this issue 8 months ago • 2 comments

Hey @dan-mm

we had a nasty issue that the tests were not running correctly because the run_until function does not automatic cleanup.

My question is: Why?

Is this behaviour somewhere needed? IT seems very risky to have no automatic cleanup as the metric providers not being properly closed will cascade into other tests and makes this very hard to find.

@davidkopp Tagged you fyi. If you write a new test please use the cleanup guard clause for the moment as done in PR https://github.com/green-coding-berlin/green-metrics-tool/pull/616 . As you can see we are discussing internally if we fix that test suite design, as it is very unintuitive that a specifically written test case can destroy other test cases

ArneTR avatar Dec 22 '23 09:12 ArneTR