mediainfo icon indicating copy to clipboard operation
mediainfo copied to clipboard

Don't assume strings are mutable

Open chocolateboy opened this issue 4 years ago • 3 comments

Avoid a FrozenError when strings are frozen globally, e.g. via --enable=frozen-string-literal.

chocolateboy avatar Nov 15 '21 22:11 chocolateboy

Hi @chocolateboy , can you write a test for this?

NorseGaud avatar Nov 15 '21 22:11 NorseGaud

I've tested it manually. You can test it automatically by adding:

# frozen_string_literal: true

to the start of every ruby file (which is recommended anyway). That way all specs test it.

chocolateboy avatar Nov 15 '21 23:11 chocolateboy

Sorry, I don't have a ruby environment anymore and really can't merge anything that doesn't have a test. Maybe one of the other maintainers of this repo can take a look. I don't think there are any other maintainers that are active for this repo :(

NorseGaud avatar Nov 15 '21 23:11 NorseGaud