react-facebook-login icon indicating copy to clipboard operation
react-facebook-login copied to clipboard

How's the mobile support and the suggestion

Open Tokenyet opened this issue 3 years ago • 7 comments

At first glance, the source code is based on keppelen/react-facebook-login. And there is a big unsolved issue on Mobile, especially newer iOS safari.

The more interesting is that you remove the isMobile and disableMobileRedirect in this package.

That comes the question, how did you slove It?

I think this is the most interesting thing that encourage others to use this package, and you might want to add in Readme 😄

By the way, I didn't use official version, because the bad typescript support, I need to use the fork version to get render. Hope this package could replace successfully 👍

Tokenyet avatar May 20 '21 02:05 Tokenyet

Didn't catch that issue.. I will try to solve it! thank u for interest! 😃

greatSumini avatar Jun 06 '21 15:06 greatSumini

I just tested on iOS and it's working with tihs package.

By the way, I didn't use official version, because the bad typescript support, I need to use the fork version to get render. Hope this package could replace successfully 👍

this package also supports render.

mifi avatar Aug 19 '22 13:08 mifi

Any updates on this? Still broken for in-app browsers which is what the original issue states.

cgarrovillo avatar Feb 15 '23 00:02 cgarrovillo

@cgarrovillo

i just released v3.3.2, including suggested solution in original issue can u try it?

greatSumini avatar Feb 15 '23 04:02 greatSumini

I think additional documentation is now needed, since the onSuccess and onFail functions are not applicable anymore when using useRedirect

cgarrovillo avatar Feb 15 '23 19:02 cgarrovillo

Hi for my - the fb login in Facebook bowser didn't work.

this is my config:

              { <FacebookLogin
                            appId={config.FACEBOOK_LOGIN_CLIENTID}
                            autoLoad={false}
                            useRedirect={true}
                            fields="name,email,picture"
                            onProfileSuccess ={componentClicked}
                            onSuccess={responseFacebook} 
                            onFail={handleFailureSignup}
                            style={{
                                backgroundColor: '#4267b2',
                                color: '#fff',
                                fontSize: '16px',
                                padding: '12px 24px',
                                border: 'none',
                                borderRadius: '4px',
                              }}
                        /> } 

any advice how to solved it? @greatSumini

aviram120 avatar Mar 18 '23 14:03 aviram120

It doesn't work for me either. In the desktop browser, it opens a pop-up to perform the login, if it tries to do the same in an embedded browser it will fail, which is what I think is happening.

timothylui avatar Nov 08 '23 11:11 timothylui