loon icon indicating copy to clipboard operation
loon copied to clipboard

Tcl package version shows as 1.2.3 in 1.3.8 download

Open apnadkarni opened this issue 3 years ago • 3 comments

Describe the bug Doing a package require loon after downloading the 1.3.8 loon release from github returns 1.2.3 as the package version, not 1.3.8. Is this expected behavior?

To Reproduce See above.

Expected behavior Expected to see 1.3.8 as the package version.

Screenshots N/A

Desktop (please complete the following information):

  • Windows 10, Tcl 8.6.11

apnadkarni avatar Oct 16 '21 03:10 apnadkarni

I do not encounter such issue. Would you please show more details (e.g. your code)?

> devtools::install_github("great-northern-diver/loon", subdir = "R")
> packageVersion("loon")
[1] ‘1.3.8’

z267xu avatar Oct 16 '21 12:10 z267xu

Thanks for the quick response. All I did was a package require loon in Tcl.

(src) 1 % package require loon
1.2.3

The top of the pkgIndex.tcl file contains these lines:

package ifneeded loon 1.2.3 "
   package provide loon 1.2.3 

Is it possible the Tcl package versions and the R package versions are different by design?

See https://github.com/great-northern-diver/loon/blob/cf969b4570a7e40b33a62649451fbb4e27d127e6/Tcl/pkgIndex.tcl#L2

apnadkarni avatar Oct 16 '21 16:10 apnadkarni

I see. After loon 1.2.3, most changes are made in R so that the "version" in tcltk is not up to date. Thanks for pointing this out.

z267xu avatar Oct 17 '21 03:10 z267xu