great_expectations_action icon indicating copy to clipboard operation
great_expectations_action copied to clipboard

Updated nodejs version to LTS to avoid compatibility issues with npm

Open sravantit25 opened this issue 2 years ago • 3 comments

Fix for the below issue: https://github.com/great-expectations/great_expectations_action/issues/79

Summary: great_expectations_action build docker image is failing with incompatible Node.js version

sravantit25 avatar May 09 '22 16:05 sravantit25

@cla-bot check

sravantit25 avatar May 09 '22 16:05 sravantit25

Howdy, the team raises a very strong point, which is can we just pin a version of node rather than have a remote script.

The script points to the Long Term Supported version (LTS) which will automatically get upgraded to the next supported version when this version gets outdated. The link always remains updated. But if this is really a concern, I will update it to a specific version. Do let me know.

sravantit25 avatar May 11 '22 17:05 sravantit25

Hello! Can you let me know your thoughts on the above PR? I can make the change if required, submit for review and close it! Thank you!

sravantit25 avatar Jun 01 '22 05:06 sravantit25

I'm going to merge this as-is, but also mark this action as explicitly no longer maintained. With changes to the underlying GX that have happened in the past couple of years, we recommend using checkpoints directly now!

jcampbell avatar Jan 14 '23 15:01 jcampbell