great_expectations icon indicating copy to clipboard operation
great_expectations copied to clipboard

[MAINTENANCE] Remove context root directory search logic within `SerializableDataContext`

Open cdkini opened this issue 9 months ago β€’ 2 comments

In 0.18.x, the context would search up to 4 levels up in a file/directory structure to find a GX project. This feels a bit too magical and results in difficult to diagnose bugs.

  • [x] Description of PR changes above includes a link to an existing GitHub issue
  • [x] PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • [x] Code is linted - run invoke lint (uses ruff format + ruff check)
  • [x] Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

cdkini avatar May 08 '24 21:05 cdkini

Deploy Preview for niobium-lead-7998 canceled.

Name Link
Latest commit 77e17741b1a812115763c74158ac70db41a79493
Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/663d2a2365a65d0008100182

netlify[bot] avatar May 08 '24 21:05 netlify[bot]

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.32%. Comparing base (ed3b5b4) to head (77e1774).

Files Patch % Lines
..._context/data_context/serializable_data_context.py 90.90% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9904      +/-   ##
===========================================
+ Coverage    77.28%   77.32%   +0.03%     
===========================================
  Files          492      492              
  Lines        42006    41971      -35     
===========================================
- Hits         32465    32453      -12     
+ Misses        9541     9518      -23     
Flag Coverage Ξ”
3.10 63.75% <54.54%> (+0.02%) :arrow_up:
3.11 63.75% <54.54%> (+0.02%) :arrow_up:
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.66% <18.18%> (+0.02%) :arrow_up:
3.11 aws_deps 44.77% <54.54%> (+<0.01%) :arrow_up:
3.11 big 54.24% <54.54%> (+0.01%) :arrow_up:
3.11 databricks 45.93% <18.18%> (+0.02%) :arrow_up:
3.11 filesystem 59.19% <90.90%> (+0.02%) :arrow_up:
3.11 mssql 48.77% <18.18%> (+0.02%) :arrow_up:
3.11 mysql 48.82% <18.18%> (+0.02%) :arrow_up:
3.11 postgresql 52.70% <18.18%> (+0.02%) :arrow_up:
3.11 snowflake 46.56% <18.18%> (+0.02%) :arrow_up:
3.11 spark 56.33% <18.18%> (+0.03%) :arrow_up:
3.11 trino 50.76% <18.18%> (+0.02%) :arrow_up:
3.8 63.77% <54.54%> (+0.02%) :arrow_up:
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.67% <18.18%> (+0.02%) :arrow_up:
3.8 aws_deps 44.79% <54.54%> (+<0.01%) :arrow_up:
3.8 big 54.25% <54.54%> (+0.01%) :arrow_up:
3.8 databricks 45.94% <18.18%> (+0.02%) :arrow_up:
3.8 filesystem 59.20% <90.90%> (+0.02%) :arrow_up:
3.8 mssql 48.75% <18.18%> (+0.02%) :arrow_up:
3.8 mysql 48.81% <18.18%> (+0.02%) :arrow_up:
3.8 postgresql 52.68% <18.18%> (+0.02%) :arrow_up:
3.8 snowflake 46.57% <18.18%> (+0.01%) :arrow_up:
3.8 spark 56.30% <18.18%> (+0.03%) :arrow_up:
3.8 trino 50.74% <18.18%> (+0.02%) :arrow_up:
3.9 63.77% <54.54%> (+0.02%) :arrow_up:
cloud 0.00% <0.00%> (ΓΈ)
docs-basic 47.38% <90.90%> (+0.01%) :arrow_up:
docs-creds-needed 48.43% <90.90%> (+0.01%) :arrow_up:
docs-spark 47.10% <90.90%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 08 '24 21:05 codecov[bot]