great_expectations icon indicating copy to clipboard operation
great_expectations copied to clipboard

[MAINTENANCE] Remove BaseDatasource

Open tyler-hoffman opened this issue 9 months ago β€’ 1 comments

  • [ ] Description of PR changes above includes a link to an existing GitHub issue
  • [ ] PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • [ ] Code is linted - run invoke lint (uses ruff format + ruff check)
  • [ ] Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

tyler-hoffman avatar May 08 '24 19:05 tyler-hoffman

Deploy Preview for niobium-lead-7998 canceled.

Name Link
Latest commit 5f66834a88bb144fe3f95b6cdd702ec7919fa67e
Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/663e6691552d970008e00a25

netlify[bot] avatar May 08 '24 19:05 netlify[bot]

Codecov Report

Attention: Patch coverage is 79.54545% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 77.24%. Comparing base (1363bf7) to head (5f66834). Report is 1 commits behind head on develop.

Files Patch % Lines
...data_context/data_context/abstract_data_context.py 66.66% 7 Missing :warning:
...ns/data_context/data_context/cloud_data_context.py 50.00% 1 Missing :warning:
...ions/data_context/migrator/configuration_bundle.py 66.66% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9901      +/-   ##
===========================================
- Coverage    77.28%   77.24%   -0.05%     
===========================================
  Files          492      491       -1     
  Lines        42006    41817     -189     
===========================================
- Hits         32465    32300     -165     
+ Misses        9541     9517      -24     
Flag Coverage Ξ”
3.10 63.53% <72.72%> (-0.21%) :arrow_down:
3.10 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 databricks ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 snowflake ?
3.10 spark ?
3.10 trino ?
3.11 63.53% <72.72%> (-0.21%) :arrow_down:
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.67% <56.81%> (+0.03%) :arrow_up:
3.11 aws_deps 44.73% <45.45%> (-0.04%) :arrow_down:
3.11 big 54.24% <56.81%> (+0.01%) :arrow_up:
3.11 databricks 45.91% <54.54%> (+<0.01%) :arrow_up:
3.11 filesystem 59.02% <68.18%> (-0.16%) :arrow_down:
3.11 mssql 48.78% <43.18%> (+0.03%) :arrow_up:
3.11 mysql 48.83% <43.18%> (+0.03%) :arrow_up:
3.11 postgresql 52.70% <56.81%> (+0.02%) :arrow_up:
3.11 snowflake 46.55% <54.54%> (+<0.01%) :arrow_up:
3.11 spark 56.29% <65.90%> (-0.01%) :arrow_down:
3.11 trino 50.76% <54.54%> (+0.02%) :arrow_up:
3.8 63.55% <72.72%> (-0.21%) :arrow_down:
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.67% <56.81%> (+0.03%) :arrow_up:
3.8 aws_deps 44.74% <45.45%> (-0.04%) :arrow_down:
3.8 big 54.25% <56.81%> (+0.01%) :arrow_up:
3.8 databricks 45.93% <54.54%> (+<0.01%) :arrow_up:
3.8 filesystem 59.03% <68.18%> (-0.16%) :arrow_down:
3.8 mssql 48.76% <43.18%> (+0.03%) :arrow_up:
3.8 mysql 48.81% <43.18%> (+0.03%) :arrow_up:
3.8 postgresql 52.68% <56.81%> (+0.02%) :arrow_up:
3.8 snowflake 46.56% <54.54%> (+<0.01%) :arrow_up:
3.8 spark 56.26% <65.90%> (-0.02%) :arrow_down:
3.8 trino 50.74% <54.54%> (+0.02%) :arrow_up:
3.9 63.54% <72.72%> (-0.21%) :arrow_down:
3.9 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.9 aws_deps ?
3.9 big ?
3.9 databricks ?
3.9 filesystem ?
3.9 mssql ?
3.9 mysql ?
3.9 postgresql ?
3.9 snowflake ?
3.9 spark ?
3.9 trino ?
cloud 0.00% <0.00%> (ΓΈ)
docs-basic 47.43% <56.81%> (+0.06%) :arrow_up:
docs-creds-needed 48.50% <54.54%> (+0.07%) :arrow_up:
docs-spark 47.16% <54.54%> (+0.07%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 10 '24 14:05 codecov[bot]