great_expectations icon indicating copy to clipboard operation
great_expectations copied to clipboard

S3 Asset e2e annotated with TODOs

Open jcampbell opened this issue 9 months ago • 2 comments

  • [ ] Description of PR changes above includes a link to an existing GitHub issue
  • [ ] PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • [ ] Code is linted - run invoke lint (uses ruff format + ruff check)
  • [ ] Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

jcampbell avatar May 03 '24 16:05 jcampbell

Deploy Preview for niobium-lead-7998 ready!

Name Link
Latest commit 7cae6eb40198cfa9cf850db468f7561205fcea5a
Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/663905e009af190008c08427
Deploy Preview https://deploy-preview-9876.docs.greatexpectations.io
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 03 '24 16:05 netlify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.21%. Comparing base (9b525ca) to head (7cae6eb). Report is 327 commits behind head on develop.

:exclamation: There is a different number of reports uploaded between BASE (9b525ca) and HEAD (7cae6eb). Click for more details.

HEAD has 26 uploads less than BASE
Flag BASE (9b525ca) HEAD (7cae6eb)
3.11 big 1 0
3.11 aws_deps 1 0
3.8 aws_deps 1 0
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 1 0
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 1 0
3.8 big 1 0
3.8 filesystem 1 0
3.11 filesystem 1 0
3.8 databricks 1 0
3.11 databricks 1 0
docs-spark 1 0
3.8 mysql 1 0
3.11 mysql 1 0
3.11 postgresql 1 0
3.8 postgresql 1 0
3.8 mssql 1 0
docs-basic 1 0
3.11 mssql 1 0
cloud 1 0
docs-creds-needed 1 0
3.11 trino 1 0
3.8 trino 1 0
3.8 spark 1 0
3.11 spark 1 0
3.8 snowflake 1 0
3.11 snowflake 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #9876       +/-   ##
============================================
- Coverage    78.61%   64.21%   -14.41%     
============================================
  Files          484      493        +9     
  Lines        42394    42537      +143     
============================================
- Hits         33330    27316     -6014     
- Misses        9064    15221     +6157     
Flag Coverage Δ
3.10 64.21% <ø> (-0.26%) :arrow_down:
3.11 64.21% <ø> (-0.26%) :arrow_down:
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.11 aws_deps ?
3.11 big ?
3.11 databricks ?
3.11 filesystem ?
3.11 mssql ?
3.11 mysql ?
3.11 postgresql ?
3.11 snowflake ?
3.11 spark ?
3.11 trino ?
3.8 64.23% <ø> (-0.26%) :arrow_down:
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.8 aws_deps ?
3.8 big ?
3.8 databricks ?
3.8 filesystem ?
3.8 mssql ?
3.8 mysql ?
3.8 postgresql ?
3.8 snowflake ?
3.8 spark ?
3.8 trino ?
3.9 64.23% <ø> (-0.26%) :arrow_down:
cloud ?
docs-basic ?
docs-creds-needed ?
docs-spark ?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 03 '24 17:05 codecov[bot]

@tyler-hoffman I am closing this because the content was merged into the demo repo.

jcampbell avatar Oct 01 '24 18:10 jcampbell