great_expectations icon indicating copy to clipboard operation
great_expectations copied to clipboard

[FEATURE] Remove batching_regex as arg to FilePathDataConnectors

Open joshua-stauffer opened this issue 10 months ago • 2 comments

This PR removes batching_regex as a parameter to FilePathDataConnector and any inheriting classes.

previous work

  • https://github.com/great-expectations/great_expectations/pull/9704
  • https://github.com/great-expectations/great_expectations/pull/9706
  • https://github.com/great-expectations/great_expectations/pull/9710
  • https://github.com/great-expectations/great_expectations/pull/9717
  • https://github.com/great-expectations/great_expectations/pull/9721

joshua-stauffer avatar Apr 05 '24 13:04 joshua-stauffer

Deploy Preview for niobium-lead-7998 ready!

Name Link
Latest commit 22d13bfeb9c905acb050bbb64224be6ab2812e14
Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/66104dca49d26a0008b3584f
Deploy Preview https://deploy-preview-9715.docs.greatexpectations.io
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 05 '24 13:04 netlify[bot]

Codecov Report

Attention: Patch coverage is 92.85714% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 64.63%. Comparing base (b3d4769) to head (ab7661f).

:exclamation: Current head ab7661f differs from pull request most recent head b0358bd. Consider uploading reports for the commit b0358bd to get more accurate results

Files Patch % Lines
...a_asset/data_connector/file_path_data_connector.py 80.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #9715       +/-   ##
============================================
- Coverage    82.55%   64.63%   -17.92%     
============================================
  Files          511      509        -2     
  Lines        46482    46479        -3     
============================================
- Hits         38371    30042     -8329     
- Misses        8111    16437     +8326     
Flag Coverage Δ
3.10 64.63% <92.85%> (-0.01%) :arrow_down:
3.11 64.63% <92.85%> (-0.01%) :arrow_down:
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.11 aws_deps ?
3.11 big ?
3.11 databricks ?
3.11 filesystem ?
3.11 mssql ?
3.11 mysql ?
3.11 postgresql ?
3.11 snowflake ?
3.11 spark ?
3.11 trino ?
3.8 64.64% <92.85%> (+<0.01%) :arrow_up:
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.8 aws_deps ?
3.8 big ?
3.8 databricks ?
3.8 filesystem ?
3.8 mssql ?
3.8 mysql ?
3.8 postgresql ?
3.8 snowflake ?
3.8 spark ?
3.8 trino ?
3.9 64.63% <92.85%> (+0.01%) :arrow_up:
cloud ?
docs-basic ?
docs-creds-needed ?
docs-spark ?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 05 '24 13:04 codecov[bot]