great_expectations icon indicating copy to clipboard operation
great_expectations copied to clipboard

[MAINTENANCE] Lint Docs

Open Kilo59 opened this issue 1 year ago • 3 comments

Enable linting for the docs directory code. Mostly involved swapping os.path and glob usage with pathlib.Path methods.

  • [x] Description of PR changes above includes a link to an existing GitHub issue
  • [x] PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • [x] Code is linted - run invoke lint (uses black + ruff)
  • [x] Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Kilo59 avatar Nov 06 '23 23:11 Kilo59

Deploy Preview for niobium-lead-7998 canceled.

Name Link
Latest commit 124d9913c64a661b5911d841d02cd0fa5681531b
Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/66072ac999c702000883c032

netlify[bot] avatar Nov 06 '23 23:11 netlify[bot]

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

ghost avatar Nov 06 '23 23:11 ghost

@anthonyburdi if I wanted to manually test these changes, what we be the best way to do that?

Or would you expect the CI to fail if something was off?

Kilo59 avatar Nov 07 '23 00:11 Kilo59

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 82.55%. Comparing base (453af44) to head (124d991).

Files Patch % Lines
...eat_expectations/compatibility/docstring_parser.py 0.00% 2 Missing :warning:
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8936   +/-   ##
========================================
  Coverage    82.55%   82.55%           
========================================
  Files          511      511           
  Lines        46381    46381           
========================================
  Hits         38288    38288           
  Misses        8093     8093           
Flag Coverage Δ
3.10 64.60% <0.00%> (ø)
3.10 aws_deps ?
3.10 big ?
3.10 databricks ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.11 64.60% <0.00%> (ø)
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.98% <0.00%> (ø)
3.11 aws_deps 48.99% <0.00%> (ø)
3.11 big 64.00% <0.00%> (ø)
3.11 databricks 48.21% <0.00%> (ø)
3.11 filesystem 63.78% <0.00%> (ø)
3.11 mssql 47.43% <0.00%> (ø)
3.11 mysql 47.48% <0.00%> (ø)
3.11 postgresql 54.27% <0.00%> (ø)
3.11 snowflake 48.74% <0.00%> (-0.01%) :arrow_down:
3.11 spark 60.66% <0.00%> (ø)
3.11 trino 53.90% <0.00%> (ø)
3.8 64.60% <0.00%> (-0.02%) :arrow_down:
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.98% <0.00%> (ø)
3.8 aws_deps 49.00% <0.00%> (ø)
3.8 big 64.00% <0.00%> (ø)
3.8 databricks 48.23% <0.00%> (ø)
3.8 filesystem 63.79% <0.00%> (-0.01%) :arrow_down:
3.8 mssql 47.41% <0.00%> (ø)
3.8 mysql 47.47% <0.00%> (ø)
3.8 postgresql 54.26% <0.00%> (ø)
3.8 snowflake 48.76% <0.00%> (ø)
3.8 spark 60.62% <0.00%> (ø)
3.8 trino 53.89% <0.00%> (ø)
3.9 64.61% <0.00%> (ø)
3.9 aws_deps ?
3.9 big ?
3.9 databricks ?
3.9 mssql ?
3.9 mysql ?
3.9 postgresql ?
3.9 spark ?
3.9 trino ?
cloud 0.00% <0.00%> (ø)
docs-basic 54.50% <0.00%> (ø)
docs-creds-needed 55.07% <0.00%> (ø)
docs-spark 54.60% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 29 '24 15:03 codecov[bot]