great_expectations icon indicating copy to clipboard operation
great_expectations copied to clipboard

[BUGFIX] Update default base url for cloud API

Open jcampbell opened this issue 1 year ago • 2 comments

Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.

Changes proposed in this pull request:

After submitting your PR, CI checks will run and @cla-bot will check for your CLA signature.

For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.

In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g. closes #123).

Previous Design Review notes:

Definition of Done

Please delete options that are not relevant.

  • [ ] My code follows the Great Expectations style guide
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added unit tests where applicable and made sure that new and existing tests are passing.
  • [ ] I have run any local integration tests and made sure that nothing is broken.

Thank you for submitting!

jcampbell avatar Oct 19 '22 16:10 jcampbell

Deploy Preview for niobium-lead-7998 ready!

Name Link
Latest commit 833f6dfb77c85cd759958a724c445feba0c642ce
Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/635de1bf935c4e0008aa55a9
Deploy Preview https://deploy-preview-6176--niobium-lead-7998.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 19 '22 16:10 netlify[bot]

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

ghost avatar Oct 19 '22 16:10 ghost

~I moved renamed DEFAULT_BASE_URL -> CLOUD_BASE_URL and move it to the core/http.py~

An alternative would be to create a ~great_expectations/constants.py~ or great_expectations/data_context/cloud_constants.py file.

https://github.com/great-expectations/great_expectations/pull/6176/commits/5374b7a19f615d6a25396be8acd56a0d0c834553

Kilo59 avatar Oct 28 '22 18:10 Kilo59