great_expectations icon indicating copy to clipboard operation
great_expectations copied to clipboard

[BUGFIX] @tommy-watts-depops's prop. from #6148

Open AFineDayFor opened this issue 1 year ago • 1 comments

Changes proposed in this pull request:

  • ref https://github.com/great-expectations/great_expectations/issues/6148
  • putting this in a PR so it's more easy to read.

Definition of Done

  • [x] My code follows the Great Expectations style guide
  • [x] I have performed a self-review of my own code
  • [x] I have run any local integration tests and made sure that nothing is broken.

Thank you for submitting!

AFineDayFor avatar Oct 12 '22 19:10 AFineDayFor

Deploy Preview for niobium-lead-7998 failed.

Name Link
Latest commit 6c1ecd8c9c10a27b5d4081570cea0972b78ff967
Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/634eadea0f36c20008404308

netlify[bot] avatar Oct 12 '22 19:10 netlify[bot]

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

codesee-maps[bot] avatar Oct 17 '22 21:10 codesee-maps[bot]

@anthonyburdi Can we close this one?

tommy-watts-depop avatar Oct 18 '22 16:10 tommy-watts-depop

Closed, incorporated in https://github.com/great-expectations/great_expectations/pull/6159

anthonyburdi avatar Oct 18 '22 20:10 anthonyburdi