great_expectations icon indicating copy to clipboard operation
great_expectations copied to clipboard

[MAINTENANCE] usage-stats, & utils.py typing

Open Kilo59 opened this issue 1 year ago • 2 comments

Changes proposed in this pull request:

  • breakup pyproject.toml mypy packages (in exclude)
  • core/usage_statistics typing
  • utils.py typing

TypeGuard

This PR is our first use of a custom TypeGuard (PEP 647). Which is a way to give the type-checker additional details about the kind of type-narrowing a custom is_<SOMETHING> function was performing.

https://mypy.readthedocs.io/en/stable/type_narrowing.html?highlight=TypeGuard#user-defined-type-guards

My initial PR made several of these is_<SOMETHING> functions into TypeGuards, but I reverted them. https://github.com/great-expectations/great_expectations/pull/5925#discussion_r962095170

Numpy types

Definition of Done

Kilo59 avatar Sep 02 '22 17:09 Kilo59

Deploy Preview for niobium-lead-7998 ready!

Name Link
Latest commit b90cba0222e389f91b459284dfb6e898243a914c
Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/632cbcca9289db0009b99cd3
Deploy Preview https://deploy-preview-5925--niobium-lead-7998.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Sep 02 '22 17:09 netlify[bot]

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

codesee-maps[bot] avatar Sep 02 '22 17:09 codesee-maps[bot]