great_expectations
great_expectations copied to clipboard
[MAINTENANCE] usage-stats, & utils.py typing
Changes proposed in this pull request:
- breakup
pyproject.toml
mypy packages (inexclude
) -
core/usage_statistics
typing -
utils.py
typing
TypeGuard
This PR is our first use of a custom TypeGuard
(PEP 647).
Which is a way to give the type-checker additional details about the kind of type-narrowing a custom is_<SOMETHING>
function was performing.
https://mypy.readthedocs.io/en/stable/type_narrowing.html?highlight=TypeGuard#user-defined-type-guards
My initial PR made several of these is_<SOMETHING>
functions into TypeGuards, but I reverted them.
https://github.com/great-expectations/great_expectations/pull/5925#discussion_r962095170
Definition of Done
- [x] My code follows the Great Expectations style guide
- [x] I have performed a self-review of my own code
Deploy Preview for niobium-lead-7998 ready!
Name | Link |
---|---|
Latest commit | b90cba0222e389f91b459284dfb6e898243a914c |
Latest deploy log | https://app.netlify.com/sites/niobium-lead-7998/deploys/632cbcca9289db0009b99cd3 |
Deploy Preview | https://deploy-preview-5925--niobium-lead-7998.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
👇 Click on the image for a new way to code review
-
Make big changes easier — review code in small groups of related files
-
Know where to start — see the whole change at a glance
-
Take a code tour — explore the change with an interactive tour
-
Make comments and review — all fully sync’ed with github