great_expectations icon indicating copy to clipboard operation
great_expectations copied to clipboard

[MAINTENANCE] Profiler store unit tests

Open anthonyburdi opened this issue 2 years ago • 2 comments

~~ THIS PR IS A DRAFT ~~

Changes proposed in this pull request:

  • TBD

After submitting your PR, CI checks will run and @cla-bot will check for your CLA signature.

For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.

In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g. closes #123).

Previous Design Review notes:

Definition of Done

Please delete options that are not relevant.

  • [ ] My code follows the Great Expectations style guide
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added unit tests where applicable and made sure that new and existing tests are passing.
  • [ ] I have run any local integration tests and made sure that nothing is broken.

Thank you for submitting!

anthonyburdi avatar Aug 30 '22 22:08 anthonyburdi

Deploy Preview for niobium-lead-7998 ready!

Name Link
Latest commit fb30a5175636ba6a86c242bb7948e2405bee02b4
Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/630e93535197290009fcb2b3
Deploy Preview https://deploy-preview-5887--niobium-lead-7998.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 30 '22 22:08 netlify[bot]

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

ghost avatar Aug 30 '22 22:08 ghost

Closed, unfinished PR.

anthonyburdi avatar Oct 18 '22 20:10 anthonyburdi