great_expectations icon indicating copy to clipboard operation
great_expectations copied to clipboard

[FEATURE] S3 store backend - add possibility to access bucket assuming iam role

Open ext-gvillafane opened this issue 2 years ago • 2 comments

Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.

Changes proposed in this pull request:

  • Accept role_arn attribute to be able to reach S3 buckets through assume role operation

After submitting your PR, CI checks will run and @cla-bot will check for your CLA signature.

For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.

In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g. closes #123).

Previous Design Review notes:

Definition of Done

Please delete options that are not relevant.

  • [x] My code follows the Great Expectations style guide
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added unit tests where applicable and made sure that new and existing tests are passing.
  • [ ] I have run any local integration tests and made sure that nothing is broken.

Thank you for submitting!

ext-gvillafane avatar Aug 23 '22 20:08 ext-gvillafane

Deploy request for niobium-lead-7998 pending review.

Visit the deploys page to approve it

Name Link
Latest commit f07292fc16375c2d79768cce0e285f4b7dcf19f4

netlify[bot] avatar Aug 23 '22 20:08 netlify[bot]

Hi @ext-gvillafane - thank you so much for your contribution! Someone on the team will review and be in touch. In the meantime, it looks like the PR is failing a linting check. Could you please run the linters as we describe in our contribution docs and re-commit? Thanks!

talagluck avatar Aug 26 '22 09:08 talagluck

Hi @ext-gvillafane! Thank you for this contribution. I was just trying to make the changes that @kenwade4 suggested (lint / merge develop) but unfortunately I'm not able to push to your branch. Since this PR has been outstanding for a while I will close it but if you can either make those edits or open the branch so I can make those changes we can reopen and get this change in. Thank you!

anthonyburdi avatar Mar 22 '23 22:03 anthonyburdi