great_expectations icon indicating copy to clipboard operation
great_expectations copied to clipboard

[FEATURE] Support databricks sqlalchemy connection

Open ext-gvillafane opened this issue 2 years ago • 2 comments

Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.

Changes proposed in this pull request:

  • Support databricks as sqlalchemy dialect

After submitting your PR, CI checks will run and @cla-bot will check for your CLA signature.

For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.

In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g. closes #123).

Previous Design Review notes:

Definition of Done

Please delete options that are not relevant.

  • [x] My code follows the Great Expectations style guide
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added unit tests where applicable and made sure that new and existing tests are passing.
  • [ ] I have run any local integration tests and made sure that nothing is broken.

Thank you for submitting!

ext-gvillafane avatar Aug 23 '22 20:08 ext-gvillafane

Deploy request for niobium-lead-7998 pending review.

Visit the deploys page to approve it

Name Link
Latest commit d401e74fed816b5dbd66754ec426e29f02f16512

netlify[bot] avatar Aug 23 '22 20:08 netlify[bot]

Hi @ext-gvillafane - thank you so much for your contribution! Someone on the team will review and be in touch. In the meantime, it looks like the PR is failing a linting check. Could you please run the linters as we describe in our contribution docs and re-commit? Thanks!

talagluck avatar Aug 26 '22 09:08 talagluck

Hi @ext-gvillafane. Could you please sign our CLA, and run a code linter? Thanks!

Shinnnyshinshin avatar Jan 06 '23 17:01 Shinnnyshinshin

Hi @ext-gvillafane thank you so much for your contribution to GX. We are going to close this PR for now as there has not been activity on it for some time. If you are still interested in this contribution, please feel free to re-open the PR :) Thank you again.

Shinnnyshinshin avatar Jan 24 '23 00:01 Shinnnyshinshin