great_expectations icon indicating copy to clipboard operation
great_expectations copied to clipboard

[MAINTENANCE] Use `set` instead of `create` in DatasourceStore

Open anthonyburdi opened this issue 2 years ago • 2 comments

Changes proposed in this pull request:

  • Refactor to use set instead of create in DatasourceStore
  • Refactor test_datasource_crud.py to use parametric tests for each data context type
  • Partial refactor of private datasource creation methods to not require a name in addition to the name being in the DatasourceConfig
  • Note: schema roundtrip to deal with id vs id_ is being handled in a separate PR
  • Note: This is a partial implementation of code from https://github.com/great-expectations/great_expectations/pull/5664

Definition of Done

Please delete options that are not relevant.

  • [x] My code follows the Great Expectations style guide
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have added unit tests where applicable and made sure that new and existing tests are passing.
  • [x] I have run any local integration tests and made sure that nothing is broken.

Thank you for submitting!

anthonyburdi avatar Aug 15 '22 21:08 anthonyburdi

Deploy Preview for niobium-lead-7998 ready!

Name Link
Latest commit f970cb5cbd8ecc556c1d7a0600bdb3184f725a47
Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/631768d86bc3df0009ebf2d9
Deploy Preview https://deploy-preview-5763--niobium-lead-7998.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 15 '22 21:08 netlify[bot]

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

ghost avatar Aug 15 '22 21:08 ghost

Was incorporated in https://github.com/great-expectations/great_expectations/pull/5941, https://github.com/great-expectations/great_expectations/pull/5901, https://github.com/great-expectations/great_expectations/pull/5813 and others in Aug 2022

anthonyburdi avatar Oct 18 '22 21:10 anthonyburdi