great_expectations icon indicating copy to clipboard operation
great_expectations copied to clipboard

[BUGFIX] Update `OnboardingDataAssistant` to use `oneshot` estimator

Open NathanFarmer opened this issue 1 year ago • 2 comments

Changes proposed in this pull request:

  • Update OnboardingDataAssistant to use oneshot estimator with linear interpolation method by default

Definition of Done

  • [X] My code follows the Great Expectations style guide
  • [X] I have performed a self-review of my own code
  • [X] I have commented my code, particularly in hard-to-understand areas
  • [X] I have made corresponding changes to the documentation
  • [X] I have added unit tests where applicable and made sure that new and existing tests are passing.
  • [X] I have run any local integration tests and made sure that nothing is broken.

NathanFarmer avatar Aug 11 '22 01:08 NathanFarmer

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

ghost avatar Aug 11 '22 01:08 ghost

Deploy Preview for niobium-lead-7998 ready!

Name Link
Latest commit 2356cb0abd1db2232ae97dd1d941b39f2264c879
Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/62fa825847a7dc0009f76779
Deploy Preview https://deploy-preview-5737--niobium-lead-7998.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 11 '22 01:08 netlify[bot]

@NathanFarmer This does not provide the Estimator defaults -- let us discuss and consider all changes that need to be made (including the name change from oneshot to something more representative of our use of quantiles). Maybe something from the BoxPlot terminology could be brought to bear (https://en.wikipedia.org/wiki/John_Tukey). :-). Thanks!

alexsherstinsky avatar Aug 11 '22 07:08 alexsherstinsky