great_expectations icon indicating copy to clipboard operation
great_expectations copied to clipboard

[MAINTENANCE] Introduce NumericRangeEstimator class hierarchy and encapsulate existing estimator implementations

Open alexsherstinsky opened this issue 1 year ago • 2 comments

Scope

Having type objects the implement the estimator functionality is a useful encapsulation for code interpretability and maintenance. It introduces separation of concerns between the NumericMetricRangeMultiBatchParameterBuilder building block and different deterministic and statistical estimators that can be utilized inside it and can be introduced by any contributor easily.

Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.

Changes proposed in this pull request:

  • JIRA: GREAT-761/GREAT-1167

After submitting your PR, CI checks will run and @cla-bot will check for your CLA signature.

For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.

In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g. closes #123).

Previous Design Review notes:

Definition of Done

Please delete options that are not relevant.

  • [x] My code follows the Great Expectations style guide
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] I have added unit tests where applicable and made sure that new and existing tests are passing.
  • [x] I have run any local integration tests and made sure that nothing is broken.

Thank you for submitting!

alexsherstinsky avatar Aug 10 '22 23:08 alexsherstinsky

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

ghost avatar Aug 10 '22 23:08 ghost

Deploy Preview for niobium-lead-7998 ready!

Name Link
Latest commit 3bac055ac1bc7933493fba37cdae13913e248451
Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/62f46f1f70cd720008eb91d0
Deploy Preview https://deploy-preview-5735--niobium-lead-7998.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 10 '22 23:08 netlify[bot]