great_expectations icon indicating copy to clipboard operation
great_expectations copied to clipboard

[MAINTENANCE] Store Refactor - cloud store return types & http-errors

Open Kilo59 opened this issue 1 year ago • 2 comments

Split from https://github.com/great-expectations/great_expectations/pull/5664

Changes proposed in this pull request:

TODO

  • [ ] - request-mock

Definition of Done

Please delete options that are not relevant.

  • [x] My code follows the Great Expectations style guide
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • ~I have made corresponding changes to the documentation~
  • [x] I have added unit tests where applicable and made sure that new and existing tests are passing.
  • [x] I have run any local integration tests and made sure that nothing is broken.

Kilo59 avatar Aug 09 '22 21:08 Kilo59

Deploy Preview for niobium-lead-7998 ready!

Name Link
Latest commit 069e249ff3a645e2f6efd92c4ebf8765d4301ea8
Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/62f65a7a483792000a33e0a9
Deploy Preview https://deploy-preview-5730--niobium-lead-7998.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 09 '22 21:08 netlify[bot]

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

ghost avatar Aug 09 '22 21:08 ghost