great_expectations icon indicating copy to clipboard operation
great_expectations copied to clipboard

[WIP][MAINTENANCE] invoke docker

Open Kilo59 opened this issue 1 year ago • 2 comments

Changes proposed in this pull request:

  • minimal invoke docker task for building and/or running a local docker container

Questions to answer

What should the default workflow be? We should make this behavior the default behavior when invoke docker is called without custom arguments.

  1. Build an image locally and then run it with a local volume?
  2. Pull the latest, "official image" and run it without a local volume?
  3. Something else???

Definition of Done

Please delete options that are not relevant.

  • [ ] My code follows the Great Expectations style guide
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added unit tests where applicable and made sure that new and existing tests are passing.
  • [ ] I have run any local integration tests and made sure that nothing is broken.

Thank you for submitting!

Kilo59 avatar Aug 06 '22 00:08 Kilo59

Deploy Preview for niobium-lead-7998 ready!

Name Link
Latest commit 1476393a212665d66288541bd64682fd5f323d53
Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/62f692962051be0008cf6360
Deploy Preview https://deploy-preview-5703--niobium-lead-7998.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 06 '22 00:08 netlify[bot]

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

ghost avatar Aug 06 '22 00:08 ghost

✔️ Looks good.

Kilo59 avatar Aug 12 '22 17:08 Kilo59