great_expectations icon indicating copy to clipboard operation
great_expectations copied to clipboard

[MAINTENANCE] Config/Schema round_tripping

Open Kilo59 opened this issue 3 years ago • 3 comments

Changes proposed in this pull request:

  • dict_round_trip() classmethod for Config (AbstractConfig) to help deserialization/serialization issues related to mismatched keys - (id_ vs id).

Helper method for doing this kind of logic. https://github.com/great-expectations/great_expectations/pull/5664/files#diff-1cf90172245fa16e9942295256f93f6dd99708bdcf0d2190a4678fafcfa07519

Alternatives

class method on Config that acts like a factory and can ingest a dictionary

Definition of Done

Please delete options that are not relevant.

  • [ ] My code follows the Great Expectations style guide
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added unit tests where applicable and made sure that new and existing tests are passing.
  • [ ] I have run any local integration tests and made sure that nothing is broken.

Kilo59 avatar Aug 05 '22 16:08 Kilo59

Deploy Preview for niobium-lead-7998 ready!

Name Link
Latest commit 818fcc7f6105c14abded26def8f8a1f8b1764ce5
Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/62fc09965c2038000967780a
Deploy Preview https://deploy-preview-5697--niobium-lead-7998.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 05 '22 16:08 netlify[bot]

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

ghost avatar Aug 05 '22 16:08 ghost

A Config.factory(), or Config.from_dict() method might express the intent of this method better.

Kilo59 avatar Aug 09 '22 20:08 Kilo59