great_expectations icon indicating copy to clipboard operation
great_expectations copied to clipboard

[MAINTENANCE] Implement context.datasource_update with a cloud backend

Open anthonyburdi opened this issue 1 year ago • 2 comments

Changes proposed in this pull request:

  • Change update_by_name to update which processes a DatasourceConfig with name (populated with name in DataContext.update_datasource()`
  • Leverage _build_key_from_config()

Definition of Done

Please delete options that are not relevant.

  • [x] My code follows the Great Expectations style guide
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have added unit tests where applicable and made sure that new and existing tests are passing.
  • [x] I have run any local integration tests and made sure that nothing is broken.

Thank you for submitting!

anthonyburdi avatar Aug 02 '22 19:08 anthonyburdi

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

ghost avatar Aug 02 '22 19:08 ghost

Deploy Preview for niobium-lead-7998 ready!

Name Link
Latest commit 5ba47da44fa5fb23b96d616835f338021c833423
Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/63209bf0496ee80008737227
Deploy Preview https://deploy-preview-5652--niobium-lead-7998.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 02 '22 19:08 netlify[bot]