great_expectations icon indicating copy to clipboard operation
great_expectations copied to clipboard

[MAINTENANCE] Move test_yaml_config to a separate class

Open anthonyburdi opened this issue 2 years ago • 2 comments

Changes proposed in this pull request:

  • Pure refactor - no logic change intended.
  • Move BaseDataContext.test_yaml_config() to a separate class called YamlConfigValidator which also contains class attributes.

Definition of Done

Please delete options that are not relevant.

  • [x] My code follows the Great Expectations style guide
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have run any local integration tests and made sure that nothing is broken.

anthonyburdi avatar Jul 12 '22 00:07 anthonyburdi

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

ghost avatar Jul 12 '22 00:07 ghost

Deploy Preview for niobium-lead-7998 ready!

Name Link
Latest commit 833db9e461091c74fac56a4c6b268cb8a9aa8d58
Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6352b03a7a3b0500082355bc
Deploy Preview https://deploy-preview-5487--niobium-lead-7998.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jul 12 '22 00:07 netlify[bot]