great_expectations icon indicating copy to clipboard operation
great_expectations copied to clipboard

Teams notification failed to show data asset name

Open derek-hk opened this issue 2 years ago • 2 comments

Describe the bug Teams adaptive card failed to show data asset name, which exists in validation result.

To Reproduce Declare a batch request by class RuntimeBatchRequest, with "data_asset_name" inclusive Run a checkpoint, which contains a Teams Notification action And compare the values between teams adaptive card and validation result.

Expected behavior Data asset name should appear in the teams adaptive card

Environment (please complete the following information): Databricks Runtime 6.4 Great Expectations Version: 0.13.45

image

derek-hk avatar Dec 08 '21 07:12 derek-hk

Hey @derek-hk thanks so much for opening up this issue. This definitely seems like a bug. I'll bring this up with our engineering team and see what we can do to find a resolution.

cdkini avatar Dec 08 '21 16:12 cdkini

I can confirm this bug. Would be nice if this can be fixed :). Maybe I'll have some time in the future to help, but not right now.

DaveRuijter avatar Jan 17 '22 13:01 DaveRuijter

RE-opening to keep track.

rdodev avatar Mar 23 '23 17:03 rdodev

I have the same issue and want to add that button "Open data docs" does not work if asset name defined but not found. Is there any way to set the link manually until issue is fixed?

alicekore avatar Apr 04 '23 20:04 alicekore

Hi, I was able to reproduce and I opened a PR here: https://github.com/great-expectations/great_expectations/pull/7675

dctalbot avatar Apr 20 '23 22:04 dctalbot

@alicekore For the "Open data docs" button, are you hosting the data docs locally? URLs for files on the local filesystem use the file:// scheme, so I don't think Teams will be capable of opening those. However, if you host them remotely, the https:// links should open correctly from Teams.

dctalbot avatar Apr 20 '23 22:04 dctalbot