react-native-view-shot
react-native-view-shot copied to clipboard
port the Windows implementation to latest APIs
@ryanlntn Hi Ryan, since you are the implementer of the Windows version would you mind checking that? I'm not sure how to setup something as I'm on Mac atm
I did some renaming that should work, however there is a method "releaseCapture" that I have left unimplemented. check the Android impl for reference, basically this is an optim to "manually" clean out a snapshotted tmp file. this is for advanced usecases only (like you snapshot a lot of time a same thing). There are some internal changes like you no longer need to check if a value is here or not, the "merge with defaults" work is done once in JS as well as the type validation. the only options that are not provided are width and height (if not provided, it means user don't want any resize, like before). Also, "path" support was dropped (not sure windows impl had that anyway), "file" result was rename to "tmpfile", "jpeg" format no longer is accepted.
thanks :)
@gre I'm actually back to Mac dev myself. I'll take a look as soon as I can or perhaps my colleague @kevinvangelder who is still actively doing Window dev wouldn't mind checking it out.
Hey guys, sorry for not responding sooner, I've had my eye on this for a couple weeks but haven't found a chance to test it. I'll tryto give it a shot if I find a gap in my schedule.
ok, thanks for getting back to me :) there is one more recent feature we might add in windows too, the captureScreen method, that allows to capture the full screen. (not just a view). take the time you need, i might try to setup a windows env in some weeks too