react-native-view-shot
react-native-view-shot copied to clipboard
For fabric or expo 52 users: here is a valid patch
It seems that react-native-view-shot does not support Expo 52 (Fabric) on the Android platform at the moment. We have created a patch to fix this issue (based on [email protected]).
We have tested it in our app (expo 51 + fabric), you can try applying this patch. Hope it helps!
It seems that react-native-view-shot does not support Expo 52 (Fabric) on the Android platform at the moment. We have created a patch to fix this issue (based on [email protected]).
We have tested it in our app (expo 51 + fabric), you can try applying this patch. Hope it helps!
God bless you chief!
Hi @gre
Are you still reviewing PRs in this repo? This breaks on Android with newest versions of RN where the new architecture (Fabric) is enabled.
I can confirm that this PR fixes the ViewShot issue on Android when the new React Native architecture is enabled. However, I think it breaks it when the new architecture is not enabled. @senseFy and @tkud04 can you confirm? If that is the case then I guess this PR should be merged as a version 4.0.0 of the lib where new arch is required. New arch is also default enabled since React Native 0.76 and I've seen other libs starting to only support new arch.
👋 I'm back! I've been off for a gap year recently. looking at this 👀 I first need to reboot a working Example project so i can test it out. (NB: Brent is also co-contributor of the library and is able to release fixes if i'm off 🤗 )
Thanks @senseFy !!
Any news on this issue? We are stuck having to use old 3.8.0 to apply this patch?
Or did anyone adjust the patch for 4.0.3?