gatsby-plugin-remote-images icon indicating copy to clipboard operation
gatsby-plugin-remote-images copied to clipboard

Published 20 hours ago • verified publisher icon graysonhicks

Include skipUndefinedUrls in options

Open holly-cummins opened this issue 1 year ago • 4 comments

I noticed that #134, which resolved #120, wasn't working as I expected.

On debugging, it looked like some of the changes in the original PR were lost in the merge, so that the plugin always saw 'skipUndefinedImages' as undefined, even if it was set to true.

holly-cummins avatar Aug 02 '23 08:08 holly-cummins

Hey folks! Would be great if this fix could be release. I just debugged the same issue and the solution seems correct. Thanks in advance!

tobyS avatar Oct 01 '23 15:10 tobyS

Thanks @holly-cummins and @tobyS I will get this merged and released ASAP

graysonhicks avatar Nov 20 '23 22:11 graysonhicks

Hey! have the same issues! @graysonhicks, any news about this PR?

And Happy New Year! :)

eDubrovsky avatar Jan 03 '24 16:01 eDubrovsky

Thanks! I just followed through the same debugging process, would be awesome if this could be released.

Looks like in the project where I was using this I never switched off of my fork so I didn't notice until now.

ryan-talus avatar Feb 16 '24 03:02 ryan-talus