profile-sync-daemon icon indicating copy to clipboard operation
profile-sync-daemon copied to clipboard

Feature request: Zen Browser support

Open bkuri opened this issue 1 year ago • 1 comments

Might be pretty straightforward since it's firefox-based:

  • GitHub: https://github.com/zen-browser/desktop
  • Homepage: https://zen-browser.app/

Thanks in advance!

bkuri avatar Sep 06 '24 14:09 bkuri

I made an AUR package to implement this here: https://aur.archlinux.org/packages/profile-sync-daemon-zen

FYI a zen-browser profile is placed in /usr/share/psd/browsers and looks like this:

if [[ -d "$HOME"/.zen ]]; then
    index=0
    PSNAME="zen-browser"
    while read -r profileItem; do
        if [[ $(echo "$profileItem" | cut -c1) = "/" ]]; then
            # path is not relative
            DIRArr[$index]="$profileItem"
        else
            # we need to append the default path to give a
            # fully qualified path
            DIRArr[$index]="$HOME/.zen/$profileItem"
        fi
        (( index=index+1 ))
    done < <(grep '[Pp]'ath= "$HOME"/.zen/profiles.ini | sed 's/[Pp]ath=//')
fi

check_suffix=1

bkuri avatar Sep 17 '24 09:09 bkuri

Support for it already exists, I added it on August and it's been there since https://github.com/graysky2/profile-sync-daemon/commit/fb87ff8c8d997d8b79b52c284feb6434d06eb0fe

itsHanibee avatar Oct 09 '24 06:10 itsHanibee

@itsHanibee good to know. I think I did this because I couldn't find Zen Browser in the README.

Thanks!

bkuri avatar Oct 09 '24 16:10 bkuri

@itsHanibee good to know. I think I did this because I couldn't find Zen Browser in the README.

Thanks!

Have a point here, adding browsers available via contrib/ needs to be documented somewhere.

README or the Arch Wiki would work.

@graysky2 thoughts?

itsHanibee avatar Oct 09 '24 17:10 itsHanibee

Created PR https://github.com/graysky2/profile-sync-daemon/pull/380 that adds Zen Browser to README

ch4og avatar Oct 09 '24 17:10 ch4og

Created PR #380 that adds Zen Browser to README

Nah, gotta be more specific I feel like. Community supported programs aren't gonna work ootb, people are gonna read that Zen is supported and will just use psd like normal and leave Issues that it doesn't report properly.

More info is needed, maybe a section informing that there's "semi-official" support for certain browsers and the steps to get them set up properly.

Another thing is that if we are adding Zen to the README, it's ideal to add all the other community browsers too just for completion's sake.

itsHanibee avatar Oct 09 '24 17:10 itsHanibee