Adam Ross

Results 109 comments of Adam Ross

HTTP 415 seems appropriate per https://tools.ietf.org/html/rfc7231#section-6.5.13

While progress was made, this issue is still open because there are further aspects of error handling not defined in the Functions Framework Spec, but PHP has differences with other...

This seems like it should be done in the buildpack, rather than in the framework.

Copying in the context I put in duplicate #68: ## Background The Cloud Storage library for PHP includes a ["stream wrapper" implementation](https://github.com/googleapis/google-cloud-php/tree/master/Storage#stream-wrapper), which integrates the Cloud Storage client library with...

Answering the question in the original post about implementation approach, I'm somewhat in favor of `suggests` but not a hard dependency. (1) sounds good to me. As far as registering...

I'm in favor of a helper like this. It does seem like something that could live here or in github.com/googleapis/google-cloudevents-php @grant

I'm working on something in this space, still a bit early but happy to discuss. Next gen on [googleapis/google-cloudevents](https://github.com/googleapis/google-cloudevents) libraries.

It is not typical to use multi-stage images with Python and Node, though some could be used. Cloud Run samples use debian slim images to minimize the size.

I've got most of a first pass put together, but I'm getting a segfault that I've traced to the transformers invocation in the ToEvent return statement: https://github.com/cloudevents/sdk-go/blob/c623f8bfd7c3d7206f0aec5730460d137e3f42a8/v2/binding/to_event.go#L61 This struck me...