chromatism icon indicating copy to clipboard operation
chromatism copied to clipboard

When installing chromatism v3, console log is present in chromatism.umd.js

Open jsonnull opened this issue 7 years ago • 3 comments

If you want to see for yourself:

Browse to https://unpkg.com/[email protected]/dist/chromatism.umd.js

Perform a search for console.log

There's no console logs present in src on master... is it possible that the umd build was not built for the 3.0.0 release? What else could be causing this?

jsonnull avatar Dec 07 '17 14:12 jsonnull

I'd guess some uncommitted debug code was probably published.

That's one of the reasons I only ever release with these bash commands:

alias patch='pre-version && npm version patch && post-version'
alias feature='pre-version && npm version minor && post-version'
alias breaking='pre-version && npm version major && post-version'
alias pre-version='git diff --exit-code && npm prune && npm install -q && npm test'
alias post-version='(npm run build; exit 0) && git diff --exit-code && git push && git push --tags && npm publish'

it's saved me from bad publishes several times.

TehShrike avatar Dec 07 '17 17:12 TehShrike

@TehShrike Yep, I'm personally a fan of https://github.com/sindresorhus/np

jsonnull avatar Dec 07 '17 18:12 jsonnull

For what it's worth, chromatism2 has no console.logs.

TehShrike avatar Mar 08 '18 04:03 TehShrike