nlp-tutorial icon indicating copy to clipboard operation
nlp-tutorial copied to clipboard

May be a small mistake

Open zhangyikaii opened this issue 4 years ago • 1 comments

Excuse me, https://github.com/graykode/nlp-tutorial/blob/master/1-1.NNLM/NNLM-Torch.py#L50 The comment here may be wrong. It should be X = X.view(-1, n_step * m) # [batch_size, n_step * m]

Sorry for disturbing you.

zhangyikaii avatar Apr 29 '20 04:04 zhangyikaii

Excuse me, https://github.com/graykode/nlp-tutorial/blob/master/1-1.NNLM/NNLM-Torch.py#L50 The comment here may be wrong. It should be X = X.view(-1, n_step * m) # [batch_size, n_step * m]

Sorry for disturbing you.

hey bro, I find this mistake too, I think you are right

wmathor avatar Jun 10 '20 04:06 wmathor