graycoreio
[FEAT] DaffCartShippingRate is a confusing model
:bulb: Feature request
Feature Name
Change DaffCartShippingRate model and/or update other references.
The Desired Behavior
All references that are actually a DaffCartShippingRate should be more obvious.
Your Use Case
As an app developer, I should be able to tell what I'm getting back from the cart facade without looking at the source code.
Prior Work
I saw this problem when I noticed that the cart facade has two fields on it called availableShippingMethods$ and shippingInformation$, and both of these are actually DaffCartShippingRate models. I'm proposing that the model name should change to DaffCartShippingMethod, since that's what it appears to be, and the shippingInformation$ field should be called selectedShippingMethod$. There are probably other places where DaffCartShippingRate is referenced oddly too.
We do have a DaffCartShippingInformation model but I'm not sure how useful its only field, address_id, is. I don't think it really ever gets used anywhere.
