daffodil icon indicating copy to clipboard operation
daffodil copied to clipboard

feat(driver)!: add feature support to magento driver provider

Open griest024 opened this issue 4 weeks ago • 2 comments

PR Checklist

  • [ ] Commit message follows our contributing guidelines
  • [ ] Tests added/updated (for bug fixes/features)
  • [ ] Documentation added/updated (for bug fixes/features)

PR Type

  • [ ] Bug fix
  • [ ] Feature
  • [ ] Style update
  • [ ] Refactor
  • [ ] Test
  • [ ] Build
  • [ ] CI
  • [ ] Docs
  • [ ] Performance
  • [ ] Other (please describe)

New behavior

makes provideMagentoDriver configable with features

Breaking change?

  • [x] Yes
  • [ ] No

Additional context

griest024 avatar Dec 10 '25 15:12 griest024

This is a breaking change against @daffodil/commerce.

See: https://github.com/graycoreio/daffodil/blob/develop/tools/schematics/ng-add/generators/providers/standalone.ts#L140

We'll need to adjust this usage and validate that @daffodil/commerce 's Magento schematic works as expected.

ah yes we should really have test cases for this: #4253

griest024 avatar Dec 10 '25 20:12 griest024

@damienwebdev should be fixed now

griest024 avatar Dec 10 '25 20:12 griest024