graycoreio
Convert `NgModule`s to provider functions
Feature description
We have many packages (and subpackages) that use NgModule when instead they can now use provider functions.
- [ ] @daffodil/analytics
- [ ] @daffodil/auth
- [ ] @daffodil/authorizenet
- [ ] @daffodil/cart
- [ ] @daffodil/cart-customer
- [ ] @daffodil/cart-store-credit
- [ ] @daffodil/category
- [ ] @daffodil/checkout
- [ ] @daffodil/contact
- [ ] @daffodil/content
- [ ] @daffodil/core
- [ ] @daffodil/customer
- [ ] @daffodil/customer-auth
- [ ] @daffodil/customer-order
- [ ] @daffodil/customer-payment
- [ ] @daffodil/customer-payment-authorizenet
- [ ] @daffodil/customer-store-credit
- [ ] @daffodil/design
- [ ] @daffodil/dev-tools
- [ ] @daffodil/driver
- [ ] @daffodil/external-router
- [ ] @daffodil/forms
- [ ] @daffodil/geography
- [ ] @daffodil/navigation (@damienwebdev)
- [ ] @daffodil/newsletter (@kushagra0902)
- [ ] @daffodil/order
- [ ] @daffodil/payment
- [ ] @daffodil/paypal
- [ ] @daffodil/product
- [ ] @daffodil/product-composite
- [ ] @daffodil/product-configurable
- [ ] @daffodil/related-products
- [ ] @daffodil/reviews
- [ ] @daffodil/router
- [ ] @daffodil/router-store
- [ ] @daffodil/search
- [ ] @daffodil/search-category
- [ ] @daffodil/search-product
- [ ] @daffodil/search-product-composite
- [ ] @daffodil/search-product-configurable
- [ ] @daffodil/seo
- [ ] @daffodil/ssr
- [ ] @daffodil/upsell-products
Use case
We would like to deprecate as much @NgModule usage as possible.
Prior work
We've done this already for a few modules: https://github.com/graycoreio/daffodil/commit/6be30b078df3950a435a3470e6f6ce63cffd9619
Daffodil version
0.89.0
Additional context
If you would like to contribute to this issue, please open a PR for one provider at a time. Do not open a PR with more than a single provider in it (unless you have very strong reason) or I will just immediately close it. The only way we'll be able to do this is with good review, and the smaller the PR, the better.
If you are unsure about whether or not an @NgModule needs to be deprecated, please post a thread in discord so that this issue doesn't have too many comments.
@kris70lesgo as this is a large epic, and will likely take at least 200 total PRs, I won't assign this individually, however you are welcome to work on it and submit PRs.
@damienwebdev Hi, I am a new contributor and by now understood the structure of the repo and meaning of this issue. Now I am working on converting newsletter module. Is it fine?
@kushagra0902 absolutely! I'll mark on the checklist items that are assigned. Thanks!
@arshiyank You've been assigned. Can you post here when you've decided which package you'll be working on so I can note it in the description? Thank you.
