daffodil icon indicating copy to clipboard operation
daffodil copied to clipboard

Move sidebar mode helpers, registration, and service to daff.io

Open xelaint opened this issue 9 months ago • 3 comments

:bulb: Feature request

Feature Name

Move sidebar mode helpers to daff.io

The Desired Behavior

daffSidebarIsFloatingMode, daffSidebarIsDockedMode, DaffSidebarRegistration, and DaffSidebarService should be moved to daff.io since the usage is very specific to how we implement sidebars, not necessarily a feature we should include in the sidebar component.

Adding all of these is stretching the already onerous component too far. While it may be useful for others, it's not the responsibility of this component to handle these cases.

Your Use Case

Prior Work

Environment


Daffodil version: X.Y.Z
Angular version: X.Y.Z 

 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

xelaint avatar Apr 09 '25 14:04 xelaint

while I agree that these probably don't belong in @daffodil/design, I do think that they should be in the public API. @damienwebdev @xelaint thoughts?

griest024 avatar Apr 10 '25 14:04 griest024

@griest024 what were you thinking? A new package perhaps?

damienwebdev avatar Apr 10 '25 15:04 damienwebdev

Yeah, a new package would be ideal I think.

griest024 avatar Apr 10 '25 18:04 griest024